Attempted fix for issue #19#23
Open
MatrixFrog wants to merge 1 commit into
Open
Conversation
|
There were the following issues with your Pull Request
Guidelines are available at https://github.com/LeoNero/react-img-zoom. This message was auto-generated by https://gitcop.com |
MatrixFrog
force-pushed
the
issue-19-fix
branch
from
5ba62cd to
9d2d627
Compare
|
There were the following issues with your Pull Request
Guidelines are available at https://github.com/LeoNero/react-img-zoom. This message was auto-generated by https://gitcop.com |
MatrixFrog
force-pushed
the
issue-19-fix
branch
from
9d2d627 to
cc430fc
Compare
Read props at render time, instead of in the constructor. That way if props change we're always reading the latest values.
MatrixFrog
force-pushed
the
issue-19-fix
branch
from
cc430fc to
463b134
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Read props at render time, instead of in the constructor. That way if props change we're always reading the latest values.
I haven't tested this yet. I tried doing
yarn install && yarn testand got some error while it was trying to compile node-sass or something.